[Freeipa-devel] [PATCH 0123-0126] Separate master and forward zones (add idnsForwardZone object class)

[Petr Spacek]

On 2.4.2013 18:34, Adam Tkac wrote:
> On Fri, Mar 22, 2013 at 01:03:12PM +0100, Petr Spacek wrote:
>> >Hello,
>> >
>> >this patch set separates master zones (idnsZone objectClass) from
>> >forward zones (idnsForwardZone objectClass). Support for forward
>> >zones in idnsZone objectClass is still present to ease upgrades.
>> >
>> >See each commit message for all the gory details.
> Just check one comment below, otherwise ack.
[...]
>>
>>  		if (result == ISC_R_SUCCESS) {
>>  			log_debug(5, "Refresh %s", entry->dn);
>>  			/* Add found zone to RB-tree for later check. */
>> -			result = dns_rbt_addname(rbt, &name, NULL);
>> +			if (zone_class & LDAP_ENTRYCLASS_MASTER)
>> +				result = dns_rbt_addname(master_rbt, &name, NULL);
>> +			else
>
> In my opinion you should use "else if (zone_class & LDAP_ENTRYCLASS_FORWARD)"
> here.
>
>> +				result = dns_rbt_addname(forward_rbt, &name, NULL);
>>  		}

Fixed version pushed to master: 760bebb0e8744301420cf6e4918690ed171529a2

-- 
Petr^2 Spacek