[Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

[Ana Krivokapic]

On 04/11/2013 05:57 PM, Rob Crittenden wrote:
> Petr Viktorin wrote:
>> On 04/11/2013 12:01 AM, Rob Crittenden wrote:
>>> Ana Krivokapic wrote:
>>>> Hello,
>>>>
>>>> This patch set deprecates HBAC source hosts from IPA.
>>>>
>>>> See commit messages and the design page[1] for details.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3528
>>>>
>>>> [1] http://www.freeipa.org/page/V3/HBACSourceHosts
>>>
>>> Been a while since I've run the UI but I get an error in FF 18:
>>>
>>> Timestamp: 04/10/2013 05:43:31 PM
>>> Error: TypeError: e.messages is undefined
>>> Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
>>> Line: 1
>>
>> This probably means that you didn't rebuild the UI since 42300eb.
>> Try git clean and a fresh rebuild, or use tools in install/ui/util/
>> (Petr Vobornik is the person to ask about those).
>
> Seems to have been a remnant of a previous build. I'm guessing that 
> the UI build directories aren't covered by a clean/distclean. I 
> manually removed some files from build and it works now.
>
>>
>>> The other changes seem to operate fine. I tested with an older client
>>> and got reasonable error messages back when I tried to do the various
>>> sourcehost things.
>>>
>>> I got an unknown error message with --add-sourcehost but it did include
>>> the text that the command is deprecated so I think this is acceptable.
>>> There isn't a lot we can do, I'm sorry we didn't add this exception in
>>> the beginning.
>>>
>>> I do wonder if we should leave the warning in hbactest if sourcehost is
>>> set though, for those cases where there are already options set.
>
> So this question still remains, should we leave the sourcehost warning 
> in hbactest for another release or two?
>
> rob
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Rob and I agreed on IRC to put the sourcehost warning back in hbactest 
for now. I updated the patch 0016 accordingly. (It also needed a slight 
rebase, due to API changes that happened in the meantime.) New version 
is attached.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0016-02-Deprecate-HBAC-source-hosts-from-CLI.patch
Type: text/x-patch
Size: 32063 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130412/47056770/attachment.bin>