[Freeipa-devel] [PATCH] 0052 Add ipa-advise plugins for legacy clients

[Tomas Babej]

On 08/05/2013 08:55 PM, Alexander Bokovoy wrote:
> On Mon, 05 Aug 2013, Ana Krivokapic wrote:
>>>> +        except errors.NotFound:
>>>> +            return dict(result=False)
>>>> +
>>>> +        attr = groups_entry.get('schema-compat-lookup-sssd')
>>> same here.
>>>
>>> It needs my patch 0112 too -- it changes ipa-adtrust-install to write
>>> proper configuration options to slapi-nis configs.
>>
>> Done.
>>
>> Also, references to both relevant tickets
>> https://fedorahosted.org/freeipa/ticket/3671 and
>> https://fedorahosted.org/freeipa/ticket/3672 added to commit messages.
>>
>> Updated patches attached.
> Thanks. Few more comments now that I've ran the ipa-advise with the
> plugins:
>
> 1. We need to put downloading the certificate to both plugins.
> 2. The certificate needs to be specified in sssd.conf as well as 
> ldap.conf
>
> Also it would be nice to actually reformat comments to be shorter.
> I think it should be done on a framework level -- we have the code for
> that already in the CLI handlers. Additionally, plugin writers may want
> to have 'verbatim' comments, i.e. which would resist reformatting.
The patch 0088 should fix that. Adds a wrapped flag to the log.comment
command.

>
> The same reformatting should be applied to the list of advises shown by
> 'ipa-advise' by default. It is now a bit unreadable.
>

The patch 0089 should fix that.

Tomas

-- 
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org