[Freeipa-devel] [PATCH 0090] Allow deletion of an empty trusted range with the --force flag

[Ana Krivokapic]

1) I can now delete the default range that gets created together with the trust.
Should this be allowed?

2) There is a failing test now, because you changed the DependentEntry error to
ValidationError. Btw, isn't a DependentEntry more appropriate here?

======================================================================
FAIL: test_range[23]: idrange_del: Try to delete active AD trusted range
u'testrange10'
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/akrivoka/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py", line 271,
in <lambda>
    func = lambda: self.check(nice, **test)
  File "/home/akrivoka/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py", line 285,
in check
    self.check_exception(nice, cmd, args, options, expected)
  File "/home/akrivoka/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py", line 304,
in check_exception
    UNEXPECTED % (cmd, name, args, options, e.__class__.__name__, e)
AssertionError: Expected 'idrange_del' to raise DependentEntry, but caught
different.
  args = [u'testrange10']
  options = {'version': u'2.64'}
  ValidationError: invalid 'ID range': ID range 'testrange10' cannot be deleted
because it belongs to the active trust 'testtrust'. Remove it prior to removing
this range or use --force option.


3)
> +             doc=_('Forces deletion of an empty range even if it belongs to '
> +                   'a active trust.'),
"a active trust" -> "an active trust"

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.