[Freeipa-devel] [PATCH] EXTDOM: Do not overwrite domain_name for INP_SID

Jakub Hrozek jhrozek at redhat.com
Mon Aug 26 08:14:27 UTC 2013


Hi,

I found the problem when testing Sumit's PAC responder SSSD patches. It
seems that the domain name is always overwritten with input SID. I think
using the domain we parse out from output of getnamebysid can be safely
used, but I'm not all that familiar with the extdom plugin..
-------------- next part --------------
>From d24e37c5a32203fa2a2210a736f2c7dda5c3425e Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Sun, 25 Aug 2013 14:39:27 +0200
Subject: [PATCH] EXTDOM: Do not overwrite domain_name for INP_SID

---
 daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
index 26262e4ff411c70d562733236c071a44c0d46d7e..675fc368042373314e9416dcf7d5866cb8c9871e 100644
--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_common.c
@@ -271,8 +271,6 @@ int handle_request(struct ipa_extdom_ctx *ctx, struct extdom_req *req,
             ret = LDAP_OPERATIONS_ERROR;
             goto done;
         }
-
-        domain_name = strdup(req->data.name.domain_name);
         break;
     case INP_NAME:
         ret = asprintf(&fq_name, "%s%c%s", req->data.name.object_name,
-- 
1.8.3.1



More information about the Freeipa-devel mailing list