[Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

[Petr Viktorin]

On 12/11/2013 05:05 PM, Petr Viktorin wrote:
> On 12/10/2013 02:10 PM, Jan Cholasta wrote:
>> Hi,
>>
>> the attached patches fix <https://fedorahosted.org/freeipa/ticket/3488>.
>>
>> Honza
>
> These look great, thanks! Just a couple of questions/nicpicks.
>
> 213: ACK
> 214: ACK
> 215: ACK
> 216: ACK
> 217: ACK
> 218: ACK
>
> 219:
> Does the new method guarantee 'attributetypes' are updated before
> 'objectclasses'?
> I can move the logic to schemaupdate if needed.
>
> Why is OnlyOneValueAllowed not raised any more? It should be, since the
> method assumes get_single_value() gives correct information.
>
> Why is MOD_REPLACE no longer used when no old values are retained? Or
> (MOD_DELETE, a, None) when the new set is empty?
>
>
> 220: ACK
>
> 221:
> An ancient comment in ldapupdate still has a reference to orig_data in,
> can you remove the comment as well?
>
> 222: ACK
> 223: ACK
> 224: ACK

I spoke too soon, NACK. This line:

 > -from ipaserver.plugins import ldap2

is important, please put it back. Without it api.Backend.ldap2 will not 
be available and upgrades will fail with AttributeError.

(Yes, I know.)


> I noticed that IPASimpleLdapObject.convert_result's docstring is
> obsolete, could you update/shorten it?
>


-- 
Petr³