[Freeipa-devel] [PATCH] 0346 permission_find: Do not fail for ipasearchrecordslimit=-1

Petr Viktorin pviktori at redhat.com
Tue Dec 17 09:54:59 UTC 2013


On 12/16/2013 04:55 PM, Jan Cholasta wrote:
> Hi,
>
> On 16.12.2013 16:46, Petr Viktorin wrote:
>> Hello,
>> Honza found a failure in the new permission plugin when
>> ipasearchrecordslimit is set to -1. Here is a fix.
>>
>
> Judging from LDAPSearch.find_entries, it seems that 0 also means
> unlimited, so I think "if len(entries) > max_entries > 0" might be safer
> here.

Fixed.
I think it's clearer to spell this out since it's not really comparing 
the same quantity.

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0346.2-permission_find-Do-not-fail-for-ipasearchrecordslimi.patch
Type: text/x-patch
Size: 1467 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131217/8f98b126/attachment.bin>


More information about the Freeipa-devel mailing list