[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] 0346 permission_find: Do not fail for ipasearchrecordslimit=-1



On 17.12.2013 10:54, Petr Viktorin wrote:
On 12/16/2013 04:55 PM, Jan Cholasta wrote:
Hi,

On 16.12.2013 16:46, Petr Viktorin wrote:
Hello,
Honza found a failure in the new permission plugin when
ipasearchrecordslimit is set to -1. Here is a fix.


Judging from LDAPSearch.find_entries, it seems that 0 also means
unlimited, so I think "if len(entries) > max_entries > 0" might be safer
here.

Fixed.
I think it's clearer to spell this out since it's not really comparing
the same quantity.


ACK.

--
Jan Cholasta


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]