[Freeipa-devel] [PATCH 0024] Add OTP support to ipalib CLI

[Nathaniel McCallum]

On Tue, 2013-12-17 at 09:36 +0100, Jan Cholasta wrote:
> On 16.12.2013 18:01, Nathaniel McCallum wrote:
> > On Mon, 2013-12-16 at 17:31 +0100, Jan Cholasta wrote:
> >> Please rename _normalize_owner to _convert_owner and vice versa, to
> >> match the convention used in other plugins (sorry for noticing this
> >> earlier).
> >
> > Fixed.
> >
> >> This bit in otptoken_add should be replaced by a call to
> >> _normalize_owner (after the rename):
> >>
> >> +        # Resolve the user's dn
> >> +        owner = entry_attrs.get('ipatokenowner', None)
> >> +        if owner is not None:
> >> +            owner = self.api.Object.user.get_dn(owner)
> >> +            entry_attrs['ipatokenowner'] = owner
> >
> > Fixed.
> 
> ipalib/plugins/otptoken.py:230: [E0602(undefined-variable), 
> otptoken_add.pre_callback] Undefined variable 'owner')
> ipalib/plugins/otptoken.py:232: [E0602(undefined-variable), 
> otptoken_add.pre_callback] Undefined variable 'owner')
> 
> (just put a "owner = entry_attrs.get('ipatokenowner')" line somewhere in 
> there)

Fixed, with: owner = entry_attrs.get('ipatokenowner', None)

Nathaniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0024-7-Add-OTP-support-to-ipalib-CLI.patch
Type: text/x-patch
Size: 28498 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131217/c0914054/attachment.bin>