[Freeipa-devel] [PATCH 0026] Enable building in C99 mode

[Nathaniel McCallum]

On Tue, 2013-12-17 at 15:03 +0100, Jan Cholasta wrote:
> On 17.12.2013 14:38, Nathaniel McCallum wrote:
> > On Tue, 2013-12-17 at 08:19 +0100, Jan Cholasta wrote:
> >> Hi,
> >>
> >> On 16.12.2013 22:12, Nathaniel McCallum wrote:
> >>> Patch attached.
> >>
> >> Care to elaborate? There's no ticket or explanation why this is
> >> beneficial or necessary.
> >
> > It enables compiling with C99 features, which I personally find very
> > beneficial. I am using these features (incomplete initializers and
> > for-loop declarations) in my DS plugin code. It is 2014 after all, and
> > most recent compilers support C11 at this point (certainly all the ones
> > we care to support)...
> >
> > Nathaniel
> >
> 
> Can you put something like this explanation in the commit message please?

Attached. However, I had to disable -Werror. This breaks the standard
C99 autoconf test (AC_PROG_CC_C99).

We probably shouldn't be distributing releases with -Werror. But at the
least, we definitely shouldn't be running autoconf with it. The typical
way to do this in autotools land is to add it in the Makefile only after
autoconf runs and only if you are not building the release (make dist).

Suggestions?

Nathaniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0026-2-Enable-building-in-C99-mode.patch
Type: text/x-patch
Size: 2007 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131223/76242b96/attachment.bin>