[Freeipa-devel] [PATCH 0035] Use default.conf as flag of IPA client being installed

[Tomas Babej]

On 02/21/2013 01:50 PM, Martin Kosek wrote:
> On 02/21/2013 01:29 PM, Tomas Babej wrote:
>> On 02/21/2013 12:47 PM, Martin Kosek wrote:
>>> On 02/20/2013 10:31 AM, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> When installing / uninstalling IPA client, the checks that
>>>> determine whether IPA client is installed now take the existence
>>>> of /etc/ipa/default.conf into consideration.
>>>>
>>>> The client will not uninstall unless either something is backed
>>>> up or /etc/ipa/default.conf file does exist.
>>>>
>>>> The client will not install if something is backed up or
>>>> default.conf file does exist (unless it's installation on master).
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3331
>>>>
>>>> Tomas
>>>>
>>>>
>>> Can we create a function testing if ipa client is installed to avoid
>>> duplication of the decision logic? Something like is_ipa_configured present in
>>> ipaserver/install/installutils.py.
>>>
>>> Keep in mind that we cannot use ipaserver package as it may not be present on
>>> client.
>>>
>>> Martin
>> Moved to is_ipa_client_installed function to ipautils.py
>>
>> Updated patch attached.
>>
>> Tomas
>>
> You just created a nice import loop:
>
> ...
I made the function part of ipa-client-install script then.
We probably will not need to check whether client is installed anywhere 
else.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0035-3-Use-default.conf-as-flag-of-IPA-client-being-install.patch
Type: text/x-patch
Size: 2909 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130221/53be67cb/attachment.bin>