[Freeipa-devel] [PATCH 0028] Prevent backtrace in ipa-replica-prepare

[Rob Crittenden]

Tomas Babej wrote:
> On Fri 01 Feb 2013 08:03:37 PM CET, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> On 01/31/2013 12:05 PM, Tomas Babej wrote:
>>>> On 01/31/2013 12:03 PM, Tomas Babej wrote:
>>>>> Hi,
>>>>>
>>>>> This was a regression due to change from DatabaseError to NetworkError
>>>>> when LDAP server is down.
>>>>>
>>>>> https://fedorahosted.org/freeipa/ticket/2939
>>>>>
>>>>> Tomas
>>>>>
>>>>> _______________________________________________
>>>>> Freeipa-devel mailing list
>>>>> Freeipa-devel at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>> Clicking send too soon, patch attached :)
>>>>
>>>> Tomas
>>>
>>> I don't think that removing errors.DatabaseError is necessary. By the
>>> way,
>>> would this error (and many similar errors) be solved by a server tool
>>> refactoring that Petr Viktorin is working on? IIRC, he was about to wrap
>>> ipa-replica-prepare in a similar framework like ipa-ldap-updater.
>>>
>>> With a framework like this one, we would not have to specify separate
>>> try..catch lists in all our server manipulation tools.
>>>
>>> Martin
>>
>> Tomas, I just pushed Petr's ipa-replica-prepare framework patch and
>> from my testing this issue is resolved. Can you confirm this and close
>> your bugs/tickets as appropriate?
>>
>> It is git commit 26c498736ec8eabb8dafbc090811c92c79a8c318 in master,
>> for reference.
>>
>> rob
>>
>
> Yes, backtrace is no longer an issue.
> I closed the Trac ticket, however, I do not have necessary rights to
> close the BZ bug.
>
> Martin, could you please close Bug 842874?
> https://bugzilla.redhat.com/show_bug.cgi?id=842874
>
> Thanks,
> Tomas

Done