[Freeipa-devel] [PATCH] 370 ipa-kdb: remove memory leaks

[Sumit Bose]

On Tue, Feb 12, 2013 at 12:24:48PM +0100, Martin Kosek wrote:
> All known memory leaks caused by unfreed allocated memory or unfreed
> LDAP results (which should be also done after unsuccessful searches)
> are fixed.
> 
> One ipadb_need_retry result check was fixed as this function returns
> trust in case of a need for retry and not a zero.
> 
> https://fedorahosted.org/freeipa/ticket/3413
> 
> ---
> 
> This patch should be combined with Sumit's patch 0093 which would prevent
> kdb5kdc from crashing when it is being terminted.
> 
> If you want to run krb5kdc in valgrind, check the command in the ticket which
> would let valgrind also show symbols in dlopen'ed ipa-kdb plugin.
> 
> Martin

I haven't look closely so far, but I see the following compiler warning:

ipa_kdb_common.c: In function 'ipadb_simple_search':
ipa_kdb_common.c:175:9: warning: passing argument 1 of 'ldap_msgfree'
from incompatible pointer type [enabled by default]
In file included from ipa_kdb.h:35:0,
                 from ipa_kdb_common.c:23:
/usr/include/ldap.h:1848:1: note: expected 'struct LDAPMessage *' but argument is of type 'struct LDAPMessage **'

bye,
Sumit