[Freeipa-devel] [PATCH] 350 Upgrade process should not crash on named restart

[Martin Kosek]

On 01/15/2013 02:43 PM, Simo Sorce wrote:
> On Tue, 2013-01-15 at 13:30 +0100, Martin Kosek wrote:
>> When either dirsrv or krb5kdc is down, named service restart in
>> ipa-upgradeconfig will fail and cause a crash of the whole upgrade
>> process.
>>
>> Rather only report a failure to restart the service and continue
>> with the upgrade as it does not need the named service running. Do
>> the same precaution for pki-ca service restart.
>>
>> https://fedorahosted.org/freeipa/ticket/3350
>
> Shouldn't we note it failed and retry later ?
> Is there a risk it will be down at the end of the upgrade process ?
>
> Simo.
>

Seems like an overkill to me. It would not certainly help in this case, because 
the processes that named requires are down. As Rob suggested, user upgrading 
the IPA may be running in a lower run level for example, it that case I think 
we may not even try to restart the service.

Now when I am thinking about it, maybe we should only try to restart if the 
service is running - because otherwise it would be started later and the 
changes that were done in scope of upgrade script would be applied.

Martin