[Freeipa-devel] [PATCHES] 146-164 LDAP code refactoring (Part 4)

Mon Jan 28 15:09:17 UTC 2013

On 01/28/2013 09:34 AM, Jan Cholasta wrote:
> On 25.1.2013 14:54, Petr Viktorin wrote:
>> On 01/24/2013 03:06 PM, Petr Viktorin wrote:
>>> On 01/24/2013 10:43 AM, Petr Viktorin wrote:
>>>> On 01/22/2013 04:04 PM, Petr Viktorin wrote:
>>>>> On 01/21/2013 06:38 PM, Petr Viktorin wrote:
>>>>>> On 01/17/2013 06:27 PM, Petr Viktorin wrote:
>>>>>>> Hello,
>>>>>>> This is the first batch of changes aimed to consolidate our LDAP
>>>>>>> code.
>>>>>>> Each should be a self-contained change that doesn't break anything.
>>>>>>>
>>>>>>> These patches do some general cleanup (some of the changes might
>>>>>>> seem
>>>>>>> trivial but help a lot when grepping through the code); merge the
>>>>>>> common
>>>>>>> parts LDAPEntry, Entry and Entity classes; and move stuff that
>>>>>>> depends
>>>>>>> on an installed server out of IPASimpleLDAPObject and SchemaCache.
>>>>>>>
>>>>>>> I'm posting them early so you can see where I'm going, and so you
>>>>>>> can
>>>>>>> find out if your work will conflict with mine.
>>>>
>>>
>>> Here is a third set of patches. These apply on top of jcholast's patches
>>> 94-96.
>>>
>>
>> I found mistakes in two of the patches, attaching fixed versions.
>>
>>
>>
>> Since this patchset is becoming unwieldy, I've put it in a public repo
>> that I'll keep updated. The following command will fetch it into your
>> "pviktori-ldap-refactor" branch:
>>
>>      git fetch git://github.com/encukou/freeipa
>> ldap-refactor:pviktori-ldap-refactor
>>
>>
>
> I don't think patch 139 is necessary, I fixed this problem in patch 95
> by not including 'dn' as attribute in _entry_to_entity.
>

You're right. I'm retiring patch 139.
We'll need to use entry.dn everywhere, and add an assert so that 
entry['dn'] is never set.

Here is a fourth set of patches.

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0146-Remove-unused-bindcert-and-bindkey-arguments-to-IPAd.patch
Type: text/x-patch
Size: 1739 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0147-Turn-the-LDAPError-handler-into-a-context-manager.patch
Type: text/x-patch
Size: 9528 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0148-Remove-dbdir-binddn-bindpwd-from-IPAdmin.patch
Type: text/x-patch
Size: 4029 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0149-Remove-IPAdmin.updateEntry-calls-from-fix_replica_ag.patch
Type: text/x-patch
Size: 2072 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0150-Remove-IPAdmin.get_dns_sorted_by_length.patch
Type: text/x-patch
Size: 5327 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0151-Replace-IPAdmin.checkTask-by-replication.wait_for_ta.patch
Type: text/x-patch
Size: 4245 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0152-Introduce-LDAPEntry.get_single-for-getting-single-va.patch
Type: text/x-patch
Size: 1640 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0153-Remove-special-casing-for-missing-and-single-valued-.patch
Type: text/x-patch
Size: 1053 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0154-Replace-entry.getValue-by-entry.get_single.patch
Type: text/x-patch
Size: 29752 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0155-Replace-getList-by-a-get_entries-method.patch
Type: text/x-patch
Size: 21763 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0156-Remove-toTupleList-and-attrList-from-LDAPEntry.patch
Type: text/x-patch
Size: 2693 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0157-Rename-LDAPConnection-to-LDAPClient.patch
Type: text/x-patch
Size: 2833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0158-Replace-addEntry-with-add_entry.patch
Type: text/x-patch
Size: 10552 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0159-Replace-deleteEntry-with-delete_entry.patch
Type: text/x-patch
Size: 6389 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0160-Fix-typo-and-traceback-suppression-in-replication.py.patch
Type: text/x-patch
Size: 1173 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0161-replace-getEntry-with-get_entry-or-get_entries-if-sc.patch
Type: text/x-patch
Size: 21243 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0162-Inline-inactivateEntry-in-its-only-caller.patch
Type: text/x-patch
Size: 2251 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0163-Inline-waitForEntry-in-its-only-caller.patch
Type: text/x-patch
Size: 4567 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0164-Proxy-LDAP-methods-explicitly-rather-than-using-__ge.patch
Type: text/x-patch
Size: 2470 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130128/d49bf0ef/attachment-0018.bin>