[Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

[Petr Spacek]

On 10.7.2013 10:29, Lukas Slebodnik wrote:
> On (04/07/13 15:23), Petr Spacek wrote:
>> >Hello,
>> >
>> >several warnings from autotools popped up after upgrade to Fedora 19.
>> >Attached patches should make autotools configuration more modern.
>> >
>> >--
>> >Petr^2  Spacek
>>From 07caec808e394bfcbd898905e917731cb3778e68 Mon Sep 17 00:00:00 2001
>> >From: Petr Spacek<pspacek at redhat.com>
>> >Date: Thu, 4 Jul 2013 14:04:57 +0200
>> >Subject: [PATCH] Add missing ar check to configure.ac.
>> >
>> >Signed-off-by: Petr Spacek<pspacek at redhat.com>
>> >---
>> >configure.ac | 1 +
>> >1 file changed, 1 insertion(+)
>> >
>> >diff --git a/configure.ac b/configure.ac
>> >index 222e520e0aa61bca58cff81bea672fcab04355b3..b6d66de1b862a6860226a5f9ae4a3f33842e6100 100644
>> >--- a/configure.ac
>> >+++ b/configure.ac
>> >@@ -10,6 +10,7 @@ AC_CONFIG_HEADERS([config.h])
>> >AC_DISABLE_STATIC
>> >
>> ># Checks for programs.
>> >+AM_PROG_AR
>> >AC_PROG_CC
>> >AC_PROG_LIBTOOL
>> >
>> >--
>> >1.8.3.1
>> >
> This solution is not very portable. Automake <= 1.11 does not contain this
> macro.
>
> configure.ac:14: warning: macro `AM_PROG_AR' not found in library
> configure.ac:14: error: possibly undefined macro: AM_PROG_AR
>        If this token and others are legitimate, please use m4_pattern_allow.
>        See the Autoconf documentation.
> autoreconf: /usr/bin/autoconf failed with exit status: 1
>
> Better solution will be:
> m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
>
> You can find more information about this in mail thread
> http://lists.gnu.org/archive/html/automake/2012-05/msg00014.html

Thank you for catching this. Fixed patch is attached.

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0169-2-Add-missing-ar-check-to-configure.ac.patch
Type: text/x-patch
Size: 658 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130710/7281e13f/attachment.bin>