[Freeipa-devel] [PATCHES] 149-151 Ask for PKCS#12 password interactively

[Tomas Babej]

> >
> > Functionally ok but I found it very jarring the way the passwords were
> > prompted for. I think they should be moved after the realm question and
> > the text should be more than just the path to the filename.
> >
> > rob
> >
> 
> Moved the prompt and changed the text to "Enter <file> unlock password".
> 
> Updated patches attached.
> 
> Honza

Just a nitpick:

+    # If any of the PKCS#12 options are selected, all are required.
+    pkcs12_req = (options.dirsrv_pkcs12, options.http_pkcs12)
+    pkcs12_opt = (options.pkinit_pkcs12,)
+    if any(pkcs12_req + pkcs12_opt) and not all(pkcs12_req):
         parser.error("All PKCS#12 options are required if any are used.")

This error message is somewhat misleading, since --pkinit-pkcs12 options is not required.

Tomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130712/d5b5254c/attachment.htm>