[Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

[Ana Krivokapic]

On 07/22/2013 09:01 AM, Martin Kosek wrote:
> On 07/19/2013 11:19 PM, Dmitri Pal wrote:
>> On 07/19/2013 09:26 AM, Jan Pazdziora wrote:
>>> On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote:
>>>> Disclaimer: I have no strong feelings in this matter, it just looks
>>>> weird to me, so I'm OK with not doing it if it's general consensus.
>>>> Originally we wanted to do this change in
>>>> https://fedorahosted.org/freeipa/ticket/3569 but it was not done
>>>> because of string freeze.
>>>>
>>>> I guess you can add field suffix to every field from /etc/password
>>>> when you use it in a sentence but that doesn't necessary mean that
>>> You can. But gid exists as a concept beyond /etc/passwd. So does home
>>> directory. The GECOS field value does not, really.
>>>
>>>> it's its name. man 5 passwd doesn't use word 'field' next to GECOS
>>>> in fields description/list either. IMO our use case is the same.
>>> It says:
>>>
>>> 	GECOS	This field (sometimes called the "comment field")
>>> 		[...]
>>> 		The gcos field in the password file was
>>> 		[...]
>>>
>>>> Historically correct label would probably be 'GECOS identity' but
>>>> that's not usable today as it's purpose is more general.
>> Do we have tips in the UI?
>> May be we should add them in future to provide extra information about
>> meaning of the field or button.
>> For now I think GECOS would probably be good enough.
>> Adding "field" makes it more precise but looks weird.
> +1 for just "GECOS". Petr showed me both variants in the UI and "GECOS field"
> really looked weird.
>
> Martin
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
 
+1 for removing the word 'field'. The phrase 'GECOS field' also exists in the
following files:

install/ui/test/data/ipa_init_commands.json
install/ui/test/data/ipa_init_objects.json
install/ui/test/data/json_metadata.json

So it should be fixed there as well.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.