[Freeipa-devel] [PATCH] Two minor IPA KDB MS-PAC fixes

[Jakub Hrozek]

clang found one branch with undefined variable return and one unused
variable.
-------------- next part --------------
>From 09962a9a40cd589c4694ecab4b4faa3c39e8a4a3 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Tue, 23 Jul 2013 15:07:39 +0200
Subject: [PATCH 1/2] IPA KDB MS-PAC: return ENOMEM if allocation fails

---
 daemons/ipa-kdb/ipa_kdb_mspac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c
index 4ddf3e8662bb55bae36777bd95f62b4f7e60c154..12959a89308e800d01c6cbc81a9d0bb5239fd5d9 100644
--- a/daemons/ipa-kdb/ipa_kdb_mspac.c
+++ b/daemons/ipa-kdb/ipa_kdb_mspac.c
@@ -1842,6 +1842,7 @@ krb5_error_code ipadb_sign_authdata(krb5_context context,
                      krb5_princ_component(context, ks_client_princ, 0)->length) == 0)) {
             ipactx = ipadb_get_context(context);
             if (!ipactx) {
+                kerr = ENOMEM;
                 goto done;
             }
             if (ulc_casecmp(krb5_princ_component(context, ks_client_princ, 1)->data,
-- 
1.8.3.1

-------------- next part --------------
>From fcefc88a34f8c02f75ad48f484f00438634b9d0e Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Tue, 23 Jul 2013 15:07:52 +0200
Subject: [PATCH 2/2] IPA KDB MS-PAC: remove unused variable

---
 daemons/ipa-kdb/ipa_kdb_mspac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c
index 12959a89308e800d01c6cbc81a9d0bb5239fd5d9..87a74909602f45fff7b3820f60eca560daaa2642 100644
--- a/daemons/ipa-kdb/ipa_kdb_mspac.c
+++ b/daemons/ipa-kdb/ipa_kdb_mspac.c
@@ -1930,7 +1930,6 @@ static char *get_server_netbios_name(struct ipadb_context *ipactx)
 {
     char hostname[MAXHOSTNAMELEN + 1]; /* NOTE: this is 64, too little ? */
     char *p;
-    int ret;
 
     strncpy(hostname, ipactx->kdc_hostname, MAXHOSTNAMELEN);
     /* May miss termination */
-- 
1.8.3.1