[Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

Petr Vobornik pvoborni at redhat.com
Tue Jul 23 13:34:33 UTC 2013


On 07/23/2013 01:12 PM, Ana Krivokapic wrote:
> On 07/23/2013 12:58 PM, Petr Vobornik wrote:
>> On 07/22/2013 05:33 PM, Ana Krivokapic wrote:
>>> On 07/22/2013 09:01 AM, Martin Kosek wrote:
>>>> On 07/19/2013 11:19 PM, Dmitri Pal wrote:
>>>>> On 07/19/2013 09:26 AM, Jan Pazdziora wrote:
>>>>>> On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote:

snip

>>>>> For now I think GECOS would probably be good enough.
>>>>> Adding "field" makes it more precise but looks weird.
>>>> +1 for just "GECOS". Petr showed me both variants in the UI and "GECOS field"
>>>> really looked weird.
>>>>

>>>
>>> +1 for removing the word 'field'. The phrase 'GECOS field' also exists in the
>>> following files:
>>>
>>> install/ui/test/data/ipa_init_commands.json
>>> install/ui/test/data/ipa_init_objects.json
>>> install/ui/test/data/json_metadata.json
>>>
>>> So it should be fixed there as well.
>>>
>>
>> Fixed.
>
> ACK
>

Pushed to master.
-- 
Petr Vobornik




More information about the Freeipa-devel mailing list