[Freeipa-devel] [PATCHES 0061-0063] Extend ID range types <rebased>

Tomas Babej tbabej at redhat.com
Mon Jun 10 08:52:17 UTC 2013


On 06/07/2013 05:44 PM, Alexander Bokovoy wrote:
> On Fri, 07 Jun 2013, Tomas Babej wrote:
>> On 06/07/2013 03:41 PM, Alexander Bokovoy wrote:
>>> Hi,
>>>
>>> in patch 0061:
>>>
>>> On Fri, 07 Jun 2013, Tomas Babej wrote:
>>>> +    range_types = {
>>>> +        u'ipa-local': unicode(_(u'local domain range')),
>>>> +        u'ipa-ad-winsync': unicode(_('Active Directory winsync 
>>>> range')),
>>>> +        u'ipa-ad-trust': unicode(_('Active Directory domain range')),
>>>> +        u'ipa-ad-trust-posix': unicode(_('Active Directory trust 
>>>> range with '
>>>> +                                        'POSIX attributes')),
>>>> +        u'ipa-ipa-trust': unicode(_('IPA trust range')),
>>>> +                  }
>>> Why there is _(u'local domain range') and then others without Unicode
>>> strings? Either way is fine but there should be consistency.
>>>
>> Sure, fixed.
>>
>>> The rest of this patch would be much shorter if there wouldn't
>>> additional whitespace. Could you please git rid of that?
>>>
>> Whitespaces are intentional, these are fixes for PEP8 E302 errors.
> If they are intentional, please send them as separate patch.
>
>> Sending the whole patchset updated.
> Please split the whitespace fixes from the functional ones.
>
No problem, patches split.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0068-7-PEP8-fixes-in-idrange.py.patch
Type: text/x-patch
Size: 4608 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130610/ef9379fe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0063-7-Extend-idrange-commands-to-support-new-range-origin-.patch
Type: text/x-patch
Size: 10366 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130610/ef9379fe/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0062-7-Add-update-plugin-to-fill-in-ipaRangeType-attribute.patch
Type: text/x-patch
Size: 6609 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130610/ef9379fe/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0061-7-Add-ipaRangeType-attribute-to-LDAP-Schema.patch
Type: text/x-patch
Size: 6334 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130610/ef9379fe/attachment-0003.bin>


More information about the Freeipa-devel mailing list