[Freeipa-devel] [PATCH] 0236 Flush stream after writing service messages
Alexander Bokovoy
abokovoy at redhat.com
Tue Jun 11 12:32:19 UTC 2013
On Tue, 11 Jun 2013, Alexander Bokovoy wrote:
>On Mon, 10 Jun 2013, Petr Viktorin wrote:
>>Hello,
>>This is related to testing but can be pushed independently. It will
>>make testing master much more pleasant.
>>
>>
>>sys.stdout is buffered by default if redirected to a file.
>>This may cause automated installation to appear hung.
>>Flush the stream so that messages are written immediately.
>Despite the fact that we have abstracted out output_fd in service class,
>in existing code it is only used against sys.stdout.
>
>Just in case it would be used against different output_fd, could you please
>make flush() conditional under output_fd.isatty() condition?
On further thinking this conditioning is not really needed. So scratch
it.
ACK for the original patch.
--
/ Alexander Bokovoy
More information about the Freeipa-devel
mailing list