[Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

[Jan Cholasta]

On 20.6.2013 12:28, Tomas Babej wrote:
> Providing new version:
>    - no longer requires root access defaultly
>    - headers are printed out as comments
>
> Tomas
>

You still have reference(s) to previous names of the script in the patch:

+    """
+    Base class for advices, plugins for ipa-config-advice.
+    """

Is the --list option absolutely necessary? If I read your code 
correctly, the list of advices is also returned when you run ipa-advise 
without arguments.

Honza

-- 
Jan Cholasta