[Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

[Petr Spacek]

On 21.6.2013 11:45, Tomas Babej wrote:
> On 06/21/2013 09:32 AM, Jan Cholasta wrote:
>> On 21.6.2013 09:16, Tomas Babej wrote:
>>> I'm also thinking about propagating the --verbose, etc. options provided
>>> by default by AdminTool down to plugin level so that plugin authors can
>>> make use of them. What do you think?
>>
>> +1
>>
>
> Newly added features:
>
>   - options propagated to plugins
>   - made plugin content creation more comfortable, now 3 classes of output are
>     available (debug, comment, command)
>
> Now pretty much everything that comes into my mind is addressed, so please
> have a look
> at the current implementation.
>
> Any suggestions welcome.


> New version:
>   - provides require_root setting for plugins
What would happen if require_root = False, UID = 1234 but the plugin requires 
root access? (I.e. there is an error in the require_root value.)

I don't like this boolean, because plugin author has to test the plugin and 
maintain the boolean after each change in the plugin. From my (naive) point of 
view it is error prone and unnecessary.

Proper error handling seems like 'the right way'™ to me.

-- 
Petr^2 Spacek