[Freeipa-devel] [PATCH] 381 Preserve order of servers in ipa-client-install

Martin Kosek mkosek at redhat.com
Mon Mar 11 11:40:43 UTC 2013


On 03/07/2013 03:07 PM, Petr Viktorin wrote:
> On 03/07/2013 02:00 PM, Martin Kosek wrote:
>> When multiple servers are passed via --server option, ipadiscovery
>> module changed its order. Make sure that we preserve it.
>>
>> Also make sure that user is always warned when a tested server is
>> not available as then the server will be excluded from the fixed
>> server list.
>
> The message doesn't actually say that the server will be removed. It would be
> nice if it did.
>
> Otherwise, ACK.

Sending a patch with improved logging. User should now be more clear what 
server is failing to verify (and why).

>
>> ------
>>
>> When working on this ticket I was thinking - do we make the right thing we
>> deliberately remove a server from user-provided server list just because we
>> cannot connect to it at the moment if discovery? It may just be temporarily
>> down or something.
>>
>> Maybe we should preserve the original --server list in this case and use this
>> list when writing krb5.conf or sssd.conf. Of course, for ipa-join or other
>> active configuration commands we would have to use only the valid servers so
>> that the we do not hit the server that is currently down.
>>
>> Martin
>
> Good point, this deserves a ticket.
>

Rob, do you think this deserves to be changed? Or is this behavior indeed intended?

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-381-2-preserve-order-of-servers-in-ipa-client-install.patch
Type: text/x-patch
Size: 5193 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130311/ccf1e3f0/attachment.bin>


More information about the Freeipa-devel mailing list