[Freeipa-devel] [PATCH] 260-262 Global trust configuration page

[Endi Sukma Dewata]

On 3/12/2013 11:35 AM, Petr Vobornik wrote:
>>>> Another problem is that hidden 'Default SMB Group' is not listed.
>>>> Hence it couldn't be set again after a modification. I made the
>>>> combobox
>>>> editable (first usage, so it revealed a bug) to avoid this problem.
>>>> User can enter garbage, but the framework should handle that.
>>>
>>> This is a little difficult to use. You'll need to know that you have to
>>> type 'Default SMB Group' to go back to the default and the UI doesn't
>>> show that as an acceptable value. Possible solutions:
>>>
>>> 1. Add the 'Default SMB Group' as the first entry in the drop down list
>>> so you can reselect it again. The drop down list doesn't need to be
>>> editable.
>>>
>>> 2. Use radio buttons to separate the default value from other values:
>>>
>>>    Fallback primary group: (o) Default SMB Group
>>>                            ( ) POSIX group: [ drop down list ]
>>>
>>> Regardless, I think the server API needs to be changed to accept an
>>> empty value to go back to the default value instead of taking 'Default
>>> SMB Group'. A default value should be simple and not something that will
>>> potentially conflict with a non-default value that happens to have the
>>> same name.
>>
>> I agree. Martin is it feasible?
>
>  From other emails: Apparently its not worth the time. So I implemented #1.

OK.

> 3. Found an issue: trusctconfig-show will raise 'not found' error when
> trusts are not configured on a system. It's fixed separately in attached
> patch #268. It has similar behavior as dns pages.
>
> Also I added data .json files to patch 262 and 268, so the static
> version can be used.

The static page and the code looks good, but do you have a live server 
that I could take a look at?

There are some other issues with the static page:

When loading the UI, cert entity initialization fails saying "entity is 
undefined".

Also, the trust details page has 2 sections, but the second section has 
a blank title and 'undefined' fields. Did I miss a patch?

-- 
Endi S. Dewata