[Freeipa-devel] [PATCH] 264-265 Web UI:Certificate pages

[Petr Vobornik]

On 03/15/2013 10:12 PM, Endi Sukma Dewata wrote:
> On 3/6/2013 9:51 AM, Petr Vobornik wrote:

8><------

>>> 2. Right now the fields in the cert details page are editable although
>>> there is no Update button. If you change the value an Undo button will
>>> appear. If you try to leave the page it will show the Unsaved Changes
>>> dialog. Since there's no cert-mod operation these fields should not be
>>> editable.
>
> The certificate field is still editable. There's an undo button and
> you'll get a 'page dirty' dialog. Could we make it read-only text field?
>
>>> 3. In the cert details page if you revoke the cert it will work but an
>>> error will appear below the revocation reason field saying 'Must be an
>>> integer'.
>>
>> #2, #3: I forget to tell you, that this patch also depends on my patch
>> #261 - Fix handling of no_update flag in Web UI. Sorry. It should fix
>> it. It was pushed to master today.
>
> Everything else is fixed except for the certificate field above.
>

8><------

>>> 7. Certificate can be added/revoked/restored via certificate pages and
>>> host/service details pages. We need to make sure that if you do an
>>> operation on one page, the other pages won't show outdated information.
>>
>> Fixed.
>
> I added a cert via host details page. When I go to the cert search page
> the new cert doesn't appear until I click Refresh. The revoke/restore
> works though, the status are updated automatically in all pages.
>

8><------

>
> So the remaining issues are #2 and #7. Other than that it's ACKed. Feel
> free to fix and push.
>

Fixed (#2, #7). Also metadata updated,added.

Pushed to master, ipa-3-1.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0264-2-Web-UI-Certificate-pages.patch
Type: text/x-patch
Size: 38307 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130318/75d928d6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0265-1-Web-UI-Choose-different-search-option-for-cert-find.patch
Type: text/x-patch
Size: 10430 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130318/75d928d6/attachment-0001.bin>