[Freeipa-devel] [PATCH 0120] Fix automatic reloading of invalid zone after each change in zone data

Petr Spacek pspacek at redhat.com
Mon Mar 25 15:13:01 UTC 2013


On 25.3.2013 15:49, Adam Tkac wrote:
> On Thu, Mar 21, 2013 at 01:38:42PM +0100, Petr Spacek wrote:
>> >Hello,
>> >
>> >     Fix automatic reloading of invalid zone after each change in zone data.
>> >
>> >     Reload wasn't done when serial_autoincrement feature was disabled.
>> >
>> >     https://fedorahosted.org/bind-dyndb-ldap/ticket/102
>> >
> Ack.
>
> But before the push, please add explicit comment to ldap_get_zone_serial()
> call that the only reason of this call is to return ISC_R_SUCCESS in case the
> zone is loaded or DNS_R_NOTLOADED in case it isn't. I studied the patch for more
> then 15 minutes before I figured this.

I clarified the comment and pushed it to git. V2 branch contains rebased 
version of the patch.

master: 9e7780b067b5d6b4ca74a3cdd0e88a97f3bd84c7
v2: 1c6373b2f8952b76cb8b93ed8cba8d444d129049

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list