[Freeipa-devel] [PATCH] Define all needed rpmbuild dirs

[Rob Crittenden]

Orion Poplawski wrote:
> On 03/26/2013 05:02 PM, Rob Crittenden wrote:
>> Orion Poplawski wrote:
>>> The current makefile make assumptions about people not redefining
>>> _specdir/_rpmdir/_srpmdir.  This patch gets around that by specifying
>>> all needed directories.
>>
>> Don't we force RPMBUILD to be the local build directory? Why would you
>> want to
>> specify the files to be written elsewhere?
>>
>> rob
>
> You are assuming that by defining _topdir it is enough.  But some people
> (like myself) redefine _specdir, etc.  e.g.:
>
> %_rpmtopdir             %{_topdir}/%{name}-%{version}
> %_builddir              %{_rpmtopdir}
> %_rpmdir                %{_topdir}/RPMS
> %_sourcedir             %{_rpmtopdir}
> %_specdir               %{_rpmtopdir}
> %_srcrpmdir             %{_rpmtopdir}
>
> So the patch makes sure to actually define the macros you need to point
> to the locations you want.
>

But why would you want to? We do this specifically to keep everything 
within the development tree.

rob