[Freeipa-devel] git versions for rpms in makefile

[Simo Sorce]

On Tue, 2013-03-26 at 19:14 -0400, Rob Crittenden wrote:
> Orion Poplawski wrote:
> > This patch uses the Fedora standard for git versioning
> > (version-#.git<tag>) when making rpms.  I'm afraid I haven't been able
> > to test for the non-git version case.
> 
> What is the purpose of this? We don't do upstream releases from 
> developer build, so having the wrong Source0 doesn't seem like a big 
> deal (though I'll admit no strictly correct).

Sound like a reasonable improvement to me, and makes it sure you do not
confuse an upstream build with a developer build, I am not so sure about
using __GIT__, it's kinda annoying to type, although shell completion
here helps I guess.

I lean toward acking this approach, if you do not have objections Rob.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York