[Freeipa-devel] [PATCH 0149] Clean up PTR record synchronization code and make it more robust

Petr Spacek pspacek at redhat.com
Tue May 14 15:09:05 UTC 2013


On 14.5.2013 16:41, Tomas Babej wrote:
> On 05/13/2013 05:22 PM, Petr Spacek wrote:
>> On 13.5.2013 16:49, Simo Sorce wrote:
>>> On Mon, 2013-05-13 at 16:32 +0200, Petr Spacek wrote:
>>>> +       if ((ip = inet_addr(ip_str)) == INADDR_NONE) {
>>>
>>>
>>> This kind of construct is hard to read and debug in gdb
>>> I would suggest you do:
>>> ip = inet_addr(ip_str);
>>> if (ip == INADDER_NONE) {
>>
>> I agree, done.
>>
> I tested the patch, works fine. ACK

Pushed to master: 8d12512d0eb4445f4966fd0e326cde9823f6a0bb

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list