[Freeipa-devel] Minor error: format not a string literal and no format arguments [-Werror=format-security]
Sumit Bose
sbose at redhat.com
Thu May 30 09:35:32 UTC 2013
On Wed, May 29, 2013 at 11:26:17PM -0700, Diane Trout wrote:
> Hi,
>
> I was trying to compile freeipa on debian and the compiler threw a minor
> error.
>
> Resolve a -Werror=format-security error.
>
> ipa_extdom_extop.c: In function 'ipa_extdom_extop':
> ipa_extdom_extop.c:144:9: error: format not a string literal and no format
> arguments [-Werror=format-security]
>
> --- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
> +++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
> @@ -141,7 +141,7 @@
> free(req);
> free(res);
> if (err_msg != NULL) {
> - LOG(err_msg);
> + LOG("%s", err_msg);
> }
> slapi_send_ldap_result(pb, rc, NULL, err_msg, 0, NULL);
> return SLAPI_PLUGIN_EXTENDED_SENT_RESULT;
This is obviously correct, ACK.
Do you have a chance to resent the patch as a git formatted one? If not,
I can prepare one for you and resent it.
bye,
Sumit
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
More information about the Freeipa-devel
mailing list