[Freeipa-devel] [PATCH 0149] Clean up PTR record synchronization code and make it more robust

[Petr Spacek]

On 13.5.2013 16:49, Simo Sorce wrote:
> On Mon, 2013-05-13 at 16:32 +0200, Petr Spacek wrote:
>> +       if ((ip = inet_addr(ip_str)) == INADDR_NONE) {
>
>
> This kind of construct is hard to read and debug in gdb
> I would suggest you do:
> ip = inet_addr(ip_str);
> if (ip == INADDER_NONE) {

I agree, done.

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0149-4-Clean-up-PTR-record-synchronization-code-and-make-it.patch
Type: text/x-patch
Size: 19026 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130513/a19c8b44/attachment.bin>