[Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

[Tomas Babej]

On 05/20/2013 04:29 PM, Alexander Bokovoy wrote:
> On Mon, 20 May 2013, Tomas Babej wrote:
>> On 05/16/2013 11:16 AM, Ana Krivokapic wrote:
>>> On 05/15/2013 03:41 PM, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> When removing an ID range using idrange-del command, validation
>>>> in pre_callback ensures that the range does not belong to any
>>>> active trust. In such case, ValidationError is raised.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3615
>>>>
>>>> Tomas
>>>>
>>>>
>>>> _______________________________________________
>>>> Freeipa-devel mailing list
>>>> Freeipa-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>
>>> I suggest adding some unit tests to cover this change in functionality.
>>>
>>> -- 
>>> Regards,
>>>
>>> Ana Krivokapic
>>> Associate Software Engineer
>>> FreeIPA team
>>> Red Hat Inc.
>>>
>>>
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
>> I incorporated the unit tests. It had to use direct access to LDAP 
>> using ldapmodify since we need to create a mock AD trusted range first.
>>
>> Tomas
>
We got rid of openldap utilities now. While using python.ldap module, I 
also made the tests much more robust and added a new test case.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0057-3-Do-not-allow-removal-of-ID-range-of-an-active-trust.patch
Type: text/x-patch
Size: 8849 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130524/4ae5df51/attachment.bin>