[Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

[Martin Kosek]

On 10/17/2013 10:29 PM, Alexander Bokovoy wrote:
> On Thu, 17 Oct 2013, Ana Krivokapic wrote:
> 
>> Hello,
>>
>> This patch adds ipa-advise plugins for configuring legacy clients using
>> nss-pam-ldapd.
>>
>> https://fedorahosted.org/freeipa/ticket/3672
> Thanks. Looks good. I have one comment below
> 
>> +class config_freebsd_nss_pam_ldapd(config_base_legacy_client):
>> +    """
>> +    Legacy client configuration for FreeBSD, using nss-pam-ldapd.
>> +    """
>> +    description = ('Instructions for configuring a FreeBSD system with '
>> +                   'nss-pam-ldapd. ')
>> +
>> +    def get_info(self):
>> +        uri, base = self.get_uri_and_base()
>> +        cacrt = '/usr/local/etc/ipatest.crt'
> Is the cert file name is correct? 'ipatest.crt'? Perhaps 'ipaca.crt'
> would be a better name?

Or simply ipa.crt since it is the filename used everywhere else...

Martin