[Freeipa-devel] Reviews still needed

[Petr Viktorin]

On 10/09/2013 08:57 PM, Nathaniel McCallum wrote:
> I still need reviews on the following patches. The first two (0015 and
> 0016) should be close if not ready to merge. They have undergone four
> revisions. The third is probably in the middle of reviews. Please help
> me push this over the goal line. :)
>
> Nathaniel
>
> freeipa-npmccallum-0015-4-Add-support-for-managing-user-auth-types.patch
>   API.txt                             |   12 ++++++++----
>   VERSION                             |    2 +-
>   install/updates/50-ipaconfig.update |    1 +
>   ipalib/plugins/config.py            |    8 ++++++++
>   ipalib/plugins/user.py              |   35 ++++++++++++++++++++++------
>   5 files changed, 43 insertions(+), 15 deletions(-)

I'm waiting for your response on this one. Did you reproduce the test 
failure?

Unfortunately the other two don't apply to master. Could you rebase them?

>
> freeipa-npmccallum-0016-4-Add-RADIUS-proxy-support-to-ipalib-CLI.patch
>   API.txt                            |   95 +++++++++++++++++++++++--
>   VERSION                            |    2
>   install/share/70ipaotp.ldif        |    2
>   install/share/indices.ldif         |   10 ++
>   install/share/referint-conf.ldif   |    3
>   install/updates/10-70ipaotp.update |    2
>   install/updates/20-indices.update  |    7 +
>   install/updates/25-referint.update |    1
>   install/updates/40-otp.update      |    5 +
>   ipalib/constants.py                |    1
>   ipalib/plugins/config.py           |    2
>   ipalib/plugins/radiusproxy.py      |  138 +++++++++++++++++++++++++++++
>   ipalib/plugins/user.py             |   44 ++++++++++-
>   13 files changed, 298 insertions(+), 14 deletions(-)
>
> freeipa-npmccallum-0024-2-Add-OTP-support-to-ipalib-CLI.patch
>   API.txt                    |  101 +++++++++++++
>   VERSION                    |    2
>   freeipa.spec.in            |    2
>   ipalib/errors.py           |   16 ++
>   ipalib/plugins/config.py   |    2
>   ipalib/plugins/otptoken.py |  330 +++++++++++++++++++++++++++++++++++++
>   ipalib/plugins/user.py     |   10 +
>   7 files changed, 456 insertions(+), 7 deletions(-)



-- 
Petr³