[Freeipa-devel] [PATCH 0018] Ensure credentials structure is initialized

[Petr Viktorin]

On 09/27/2013 01:16 PM, Petr Vobornik wrote:
> On 09/27/2013 12:49 PM, Petr Viktorin wrote:
>> On 09/26/2013 04:48 PM, Nathaniel McCallum wrote:
>>> On Thu, 2013-09-26 at 12:36 +0200, Petr Viktorin wrote:
>>>> On 09/26/2013 12:07 AM, Nathaniel McCallum wrote:
>>>>> Patch attached.
>>>>>
>>>>
>>>> There's a ticket to make FreeIPA build with stricter warnings:
>>>> https://fedorahosted.org/freeipa/ticket/3896
>>>>
>>>> AFAIU this will trip -Wmissing-field-initializers.
>>>
>>> C89 (implicitly) and C99 (explicitly) define that unspecified fields in
>>> initializers have the same initialization as static storage (aka zero).
>>> This feature is both well defined and useful. We should disable that
>>> warning.
>>
>> I added a note to that ticket, warnings can be discussed there. We'll
>> probably want to coordinate with SSSD as their team has more C
>> experience.
>>
>> Back to your patch:
>> Does the issue have a ticket in Trac? Which branches does it apply to?
>>
> It has now: https://fedorahosted.org/freeipa/ticket/3953

Thanks! I've added that URL to the commit message and pushed to
master: 1acd00487fad66983ec2716cb4ef888f8813d390
ipa-3-3: c6647a09ab6d37c2acf60cd95e365598d72c6fb9

-- 
Petr³