[Freeipa-devel] [PATCHES] 0282-0286 Test improvements

[Petr Viktorin]

On 10/03/2013 06:50 PM, Petr Vobornik wrote:
> On 09/24/2013 05:42 PM, Petr Viktorin wrote:
>> Hello,
>> These patches fix issues in the test suite, mainly those in BeakerLib
>> integration.
>>
>>
>> Patch 0282:
>> When requested logs don't exist, tests shouldn't fail. The BeakerLib
>> plugin was too strict here.
>>
>> Patch 0283:
>> The Ordered plugin does not play well with generators: the generated
>> tests are run, but they're not reported plugins' hooks (startTest etc.).
>> I spent some time looking for ways to correct this, but was unsuccessful.
>> The patch disables ordering for test generators (relative to the methods
>> of a class -- the tests from one generator still run in the generated
>> order).
>> With this the BeakerLib plugin will report generated tests.
>>
>> Patch 0284:
>> This adds arguments to "test names" that the BeakerLib plugin gives to
>> generated tests.
>> The patch only adds the names to the integration tests. As it becomes
>> possible to run the rest of the suite out-of-tree, I can add them to the
>> other test generators as well.
>>
>> Patch 0285:
>> This just adds logging to Host.ldap_connect.
>>
>> Patch 0285:
>> Correct the CLITestContext context manager used in help tests to
>> re-raise unexpected exceptions.
>>
>>
>> Except 0283/0284, these can be reviewed/applied individually.
>>
>
> ACK for 0282, 0283, 0284, 0286
>
> NACK for 0285 - this patch has two issues:
> - doesn't apply on top of paramiko patches (pvi-0278)
> - has incorrect log usage: self.log("something") instead of
> self.log.debug("something") or self.log.info("something"), ...
>
> Attaching patch which replaces 0285 and applies on top of pviktorin-0278.
>

Thanks, ACK to that.
I found one more bug, pushing as one-liner.

Pushed to:
master: ef2d61faa2d76924fb20b0883da03b4e9f7087a4
ipa-3-3: f4c022a9cad559167d15625430f37897d601ea85

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0306-ipatests.test_integration.test_caless-Fix-mkdir_recu.patch
Type: text/x-patch
Size: 1065 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131003/da37d116/attachment.bin>