[Freeipa-devel] [PATCH] [DOC] 0003 Split text commands & descriptions into XML tables.

Martin Kosek mkosek at redhat.com
Tue Oct 15 15:22:00 UTC 2013


Thanks. It would be ideal, if this table is (in future) generated somehow
semi-automatically as practically all this info can be gathered from FreeIPA
code. But for now, this is great.

I see some issues with the patch though:

1) Whitespaces before tabs

I fixed some of them with
sed -i "s/\+\t$/+/g" /tmp/freeipa-jfenal-0003-Split-commands-in-proper-tables.patch

Bug there is the second issue:

2) Test&build fails:

$ git am /tmp/freeipa-jfenal-0003-Split-commands-in-proper-tables-1.patch
Applying: Split commands in proper tables
/home/mkosek/freeipa-docs/.git/rebase-apply/patch:211: space before tab in indent.
   						<row>
/home/mkosek/freeipa-docs/.git/rebase-apply/patch:212: space before tab in indent.
   							<entry>
/home/mkosek/freeipa-docs/.git/rebase-apply/patch:213: space before tab in indent.
   								 automountkey-add
/home/mkosek/freeipa-docs/.git/rebase-apply/patch:214: space before tab in indent.
   							</entry>
/home/mkosek/freeipa-docs/.git/rebase-apply/patch:215: space before tab in indent.
   							<entry>
warning: squelched 1849 whitespace errors
warning: 1854 lines add whitespace errors.


$ make test
publican build --config publican.cfg --langs en-US --formats test
...
	Processing file tmp/en-US/xml_tmp/Sudo.xml -> tmp/en-US/xml/Sudo.xml
	Processing file tmp/en-US/xml_tmp/Tools.xml -> tmp/en-US/xml/Tools.xml
*ERROR: Fatal Table Error* Table (Can't identify table) contains invalid data
Attribute cols (2) does not match number of entry elements
(XML::Element=HASH(0x3889db0))
 at /usr/share/perl5/vendor_perl/Publican/Builder.pm line 801.
make: *** [test] Error 255

Martin




More information about the Freeipa-devel mailing list