[Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

[Ana Krivokapic]

On 09/30/2013 10:02 AM, Petr Viktorin wrote:
> On 09/27/2013 03:12 PM, Martin Kosek wrote:
>> On 09/27/2013 03:00 PM, Jan Cholasta wrote:
>>> On 23.9.2013 19:41, Ana Krivokapic wrote:
>>>> On 09/19/2013 03:29 PM, Ana Krivokapic wrote:
>> ...
>>> Patch 69:
>>>
>>> I think the changes in the update file should be also done in the
>>> right LDIF
>>> files in install/share, though I don't know what is the recent
>>> consensus on this.
>>>
>>>
>>> Honza
>>>
>>
>> Last time I checked, we used to do the change both in LDIF and update
>> file. Just to avoid the LDIF become obsolete.
>>
>> Martin
>
> Rob recently said his preference is to move everything from LDIF to updates,
> and out of the the LDIF files:
> http://www.redhat.com/archives/freeipa-devel/2013-September/msg00106.html
>
> I would agree, having two places with the same information is redundant and
> error-prone.
>

Thanks Honza for the review.

I incorporated your suggestions in this updated patchset. I attached all the
patches for more convenient reviewing, but only patches 68 and 70 have changed.

I haven't done any changes in the LDIF files since the consensus seems to be not
to do that.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0068-03-Add-automember-rebuild-command.patch
Type: text/x-patch
Size: 7090 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131015/552cc927/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0069-02-Add-permissions-for-automember-rebuild-command.patch
Type: text/x-patch
Size: 2389 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131015/552cc927/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0070-03-Add-unit-tests-for-automember-rebuild-command.patch
Type: text/x-patch
Size: 23920 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131015/552cc927/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0071-Fix-error-message-when-adding-duplicate-automember-r.patch
Type: text/x-patch
Size: 3819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131015/552cc927/attachment-0003.bin>