[Freeipa-devel] [PATCH] 0288 Use a user result template in tests

[Ana Krivokapic]

On 09/30/2013 05:05 PM, Petr Viktorin wrote:
> Hello,
>
> This patch introduces an user "template" with the result of a default user
> add/show. The template is then customized and used in each test.
>
> This makes the tests shorter, and highlights the "non-default" (interesting)
> pieces of the result instead of presenting a wall of text.
>
> Also, when a new default attribute is added to user results (as is the case in
> my upcoming ACI patches), there's now only one place to change.
>
>
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK with two tiny nitpicks:

+    Attributes named in ``omit`` are removed from the result; any additional
+    or non-default values can be specified in``overrides``.
                                             ^^^^^ missing space
+    """
+    # sn can be None; this should only used from `get_admin_result`

... this should only *be* used ...



-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131018/1bac3ae7/attachment.htm>