[Freeipa-devel] [PATCH] 0062 Replace ntpdate calls with ntpd

Ana Krivokapic akrivoka at redhat.com
Wed Sep 4 13:28:06 UTC 2013


On 09/03/2013 01:15 PM, Petr Viktorin wrote:
> On 09/02/2013 05:05 PM, Ana Krivokapic wrote:
>> Hello,
>>
>> This patch addresses tickethttps://fedorahosted.org/freeipa/ticket/3797.
>>
>
> Thanks! I have a question.
>
>> -        # retry several times -- logic follows /etc/init.d/ntpdate
>> -        # implementation
>> +        # retry several times
>>           for retry in range(0, 3):
>
> What's the reason to try several times? Is it still necessary with ntpd?
> I checked /etc/init.d/ntpdate in RHEL (since Fedora doesn't have it any more)
> and I didn't see any repeating.
>

I am not sure what the reason for trying several times was. My testing didn't
reveal any need for that, but I left the code there mainly because it returns
immediately after successful sync, so there is no harm.

Attached is a version of the patch without the repetition.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0062-02-Replace-ntpdate-calls-with-ntpd.patch
Type: text/x-patch
Size: 2142 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130904/1ac31575/attachment.bin>


More information about the Freeipa-devel mailing list