[Freeipa-devel] [PATCH] Debian client support

[Petr Viktorin]

On 09/03/2013 11:00 AM, Petr Viktorin wrote:
> On 09/02/2013 11:43 PM, Timo Aaltonen wrote:
>>
>> This fixes https://fedorahosted.org/freeipa/ticket/1887
>> and
>> https://fedorahosted.org/freeipa/ticket/2455
>
> Thank you!
>
>> the first three patches fix some bugs in how python is used
>
> These look okay, I'll check when other build errors are fixed.
>
[...]
>
>> fifth fixes some compilation warnings
>
> Looks good to my eyes, perhaps a C expert can look at this one too.
> I wonder why these warnings aren't enabled in our builds, though.
>

I've built and checked patches 1, 2, 3, 5 now, and found no regressions.

I've asked Rob about why IPA explicitly disallowed to load plugins from 
symlinks. That code's author is not around anymore. The reason seems to 
be vague concerns about security, but I think we have better things to 
worry about than admins (or distros) that symlink from /usr/lib/** to 
untrusted places.
(For the record: AFAIK, Debian uses symlinks for all Python modules, so 
distro-installed plugins will be symlinks.)


ACK to those 4 patches, pushed to master: 
8c03b1dbcdf75ba76b96ccfcc148afe0e134e2d3


-- 
Petr³