[Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

[Tomas Babej]

On 04/22/2014 12:50 PM, Tomas Babej wrote:
> On 04/17/2014 02:44 PM, Alexander Bokovoy wrote:
>> You replace this by
>>      range->base_rid_set = (slapi_entry_attr_find(entry, IPA_BASE_RID,
> &attr) == -1);
>
> You probably meant "== 0". Fixed.
>
>> I know that is was in your original code, but can we get numbers
>> replaced by an enum? I'd prefer to see symbolic names used instead of
>> numbers.
> Fixed in a separate patch 0178 (attached).
>
>> Please expand the message here, may be something like
>>  LOG("Empty forest root map as trusts are not enabled on this IPA
> server\n");
>
> Fixed.
>
> Updated patchset attached.
>
> Tomas

I amended the commit message in the patch 178, whole patchset attached.

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0176-2-ipa_range_check-Fix-typo-when-comparing-strings-usin.patch
Type: text/x-patch
Size: 1714 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140423/e617abe6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0175-2-ipa_range_check-Do-not-fail-when-no-trusted-domain-i.patch
Type: text/x-patch
Size: 1933 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140423/e617abe6/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0174-2-ipa_range_check-Make-a-new-copy-of-forest_root_id-at.patch
Type: text/x-patch
Size: 1379 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140423/e617abe6/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0173-2-ipa_range_check-Connect-the-new-node-of-the-linked-l.patch
Type: text/x-patch
Size: 1057 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140423/e617abe6/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0172-2-ipa_range_check-Use-special-attributes-to-determine-.patch
Type: text/x-patch
Size: 4542 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140423/e617abe6/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0178-3-ipa_range_check-Change-range_check-return-values-fro.patch
Type: text/x-patch
Size: 6283 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140423/e617abe6/attachment-0005.bin>