[Freeipa-devel] [PATCHES] 0629-0630 test_integration.task: Add DNS A records when installing a master

[Petr Viktorin]

On 08/04/2014 12:46 PM, Martin Kosek wrote:
> On 08/04/2014 12:35 PM, Tomas Babej wrote:
>> Functionally the patches look OK, tests are passing as well.
>>
>> 629: ACK
>
> Hmm. Does this line:
>
> +                            '-e', 'wait_for_dns=30',
>
> really do anything given the environmental variable is evaluated on the server
> in the post callback? Wouldn't we rather need to update our installer to add
> this to /etc/ipa/default.conf?

Hm. Correct.
I'm retiring the patch for now, and I'll talk to Petr Špaček to see if 
we can make wait_for_dns a default, since after all any automated 
deployment could run into this.

>> 630: The only thing missing is the documentation of the new suboption in
>> the ipa-test-task manpage.
>>
>> When you add that, it's an ACK for both patches.

Added, thanks for the catch.


>> On 08/04/2014 12:21 PM, Petr Viktorin wrote:
>>> Hello,
>>> Here are some fixes to our integration tests.
>
> Maybe I miss something, but it seems to me that option name
> +        subparser.add_argument('--no-a-records', action='store_false',
> and arg name
> +        tasks.install_master(master, add_a_records=args.add_a_records)
> do not match.

You're right, I forgot the `dest`. I've tested more throroughly now.

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0630.2-test_integration.task-Add-DNS-A-records-when-install.patch
Type: text/x-patch
Size: 3871 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140804/0fd08155/attachment.bin>