[Freeipa-devel] [PATCH 0225] Remove unused variables and dead code from syncrepl_update()

[Lukas Slebodnik]

On (24/02/14 13:36), Petr Spacek wrote:
>Hello,
>
>Remove unused variables and dead code from syncrepl_update().
>
>-- 
>Petr^2 Spacek

>From 0a779d8cbf7a9d63567967600786202a060d7859 Mon Sep 17 00:00:00 2001
>From: Petr Spacek <pspacek at redhat.com>
>Date: Mon, 24 Feb 2014 13:35:23 +0100
>Subject: [PATCH] Remove unused variables and dead code from syncrepl_update().
>
>Signed-off-by: Petr Spacek <pspacek at redhat.com>
>---
> src/ldap_helper.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/src/ldap_helper.c b/src/ldap_helper.c
>index c81131101648368e209414e7612623fad4405ff3..05951fccbc655aef20177ea4a905159141665800 100644
>--- a/src/ldap_helper.c
>+++ b/src/ldap_helper.c
>@@ -4274,8 +4274,6 @@ syncrepl_update(ldap_instance_t *inst, ldap_entry_t *entry, int chgtype)
> 	dns_name_t zone_name;
> 	dns_zone_t *zone_ptr = NULL;
> 	char *dn = NULL;
>-	char *prevdn_ldap = NULL;
>-	char *prevdn = NULL;
> 	char *dbname = NULL;
> 	const char *ldap_base = NULL;
> 	isc_boolean_t isbase;
>@@ -4385,7 +4383,7 @@ syncrepl_update(ldap_instance_t *inst, ldap_entry_t *entry, int chgtype)
> 	pevent->mctx = mctx;
> 	pevent->dbname = dbname;
> 	pevent->dn = dn;
>-	pevent->prevdn = prevdn;
>+	pevent->prevdn = NULL;
> 	pevent->chgtype = chgtype;
> 	pevent->entry = entry;
> 	isc_task_send(task, (isc_event_t **)&pevent);
>@@ -4406,12 +4404,8 @@ cleanup:
> 			isc_mem_free(mctx, dbname);
> 		if (dn != NULL)
> 			isc_mem_free(mctx, dn);
>-		if (prevdn != NULL)
>-			isc_mem_free(mctx, prevdn);
> 		if (mctx != NULL)
> 			isc_mem_detach(&mctx);
>-		if (prevdn_ldap != NULL)
>-			ldap_memfree(prevdn);
> 		ldap_entry_destroy(inst->mctx, &entry);
> 		if (task != NULL)
> 			isc_task_detach(&task);
>-- 
>1.8.5.3
>

ACK

LS