[Freeipa-devel] [PATCH] 531-541 OTP UI

Petr Vobornik pvoborni at redhat.com
Thu Feb 6 12:46:41 UTC 2014


The sent patch was exactly the same as 537-1.

Correct patch attached.

On 6.2.2014 13:36, Petr Vobornik wrote:
> On 5.2.2014 20:59, Nathaniel McCallum wrote:
>> The Add Token dialog asks the user to specify a unique id. This unique
>> id should be generated instead. See how I did this in the CLI. It should
>> work in this case too.
>>
>> Nathaniel
>
> Fixed.
>
> I have not added proper handling of `optional_create` flag in Web UI,
> because it might affect details pages in unwanted manner.
>
> Because of that, otptoken dialog's `ipatokenuniqueid` field now use
> `required=false` override.
>
>>
>> On Tue, 2014-01-21 at 17:45 +0100, Petr Vobornik wrote:
>>> On 13.1.2014 17:09, Petr Vobornik wrote:
>>>> Hi,
>>>>
>>>> these patches implements the OTP Web UI.
>>>>
>>>> Last 5 patches is the OTP UI.
>>>>
>>>> First 6 patches is a little refactoring/bug fixes needed for them.
>>>> General password dialog is introduced to avoid another implementation.
>>>>
>>>> Self-service UI is implemented to be very simple. Atm user can choose
>>>> only token name. Admin interface allows to enter all values.
>>>>
>>>> It's based on the RCUE work -> we need to push RCUE first. Thanks
>>>> Nathaniel for review of the last font package. It will speed things up.
>>>>
>>>> Know bugs:
>>>> - there is clash in id's of checkboxes preventing editation of
>>>> subsequently displayed ones with the same name. Will be fixed in
>>>> separate patch.
>>>> - bugs caused by bugs in API (adding/removal of own tokens in
>>>> self-service, inability to enter key on token creation -
>>>> https://fedorahosted.org/freeipa/ticket/4099)
>>>> - datetime format (widget+validator) will be implemented in separate
>>>> patch
>>>> - no support of not reviewed CLI patches (HOTP..)
>>>>
>>>> Cgit:
>>>> http://fedorapeople.org/cgit/pvoborni/public_git/freeipa.git/log/?h=otp
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3369
>>>>
>>>
>>> Patches were rebased because of minor conflict with trusted domains
>>> patch.
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0537-3-UI-for-OTP-tokens.patch
Type: text/x-patch
Size: 15810 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140206/f06d5add/attachment.bin>


More information about the Freeipa-devel mailing list