[Freeipa-devel] [PATCH] 239 Remove sourcehostcategory from the default HBAC rule

[Jan Cholasta]

On 6.2.2014 16:04, Martin Kosek wrote:
> On 02/06/2014 01:16 PM, Jan Cholasta wrote:
>> Hi,
>>
>> the attached patch fixes <https://fedorahosted.org/freeipa/ticket/4158>.
>>
>> Honza
>
> Adding a whole new update plugin for this little change seems as a
> overengineering for me. Why does a simple "remove: sourcehostcategory: all" not
> work?

Because there is no simple "dn: ..." to put above it, since it uses 
auto-generated ipaUniqueId.

>
> Also, I would be OK with even just not adding it in new installation only. It
> is a benign attribute which also may not be deprecated in older version (and
> replicated) replicas.

If it is not removed, it will still be shown in hbacrule commands' 
output. Is it OK to remove sourcehostcategory from 
hbacrule.default_attributes? I'm not sure why it was left there when 
source hosts were deprecated.

>
> Martin
>

-- 
Jan Cholasta