[Freeipa-devel] [PATCHES 0024, 0025, 0027, 0028] Classless support for reverse domains

[Martin Basti]

On Wed, 2014-02-12 at 13:12 +0100, Martin Kosek wrote:
> On 02/12/2014 11:05 AM, Martin Basti wrote:
> > <text omitted>
> >>
> >> Pushed both patches to master, but just the first to ipa-3-3 as the test
> >> updating patch did not apply (a lot).
> >>
> >> Martin, you will need to check if DNS tests pass in ipa-3-3, I assume there are
> >> changes required.
> >>
> >> Martin
> > 
> > Patch for ipa-3-3 tests attached.
> > 
> 
> NACK.
> 
> I see one more failure:
> 
> ======================================================================
> FAIL: test_host[38]: host_add: Test that validation is enabled on adds
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
>     self.test(*self.arg)
>   File "/root/freeipa-master/ipatests/test_xmlrpc/xmlrpc_test.py", line 283, in
> <lambda>
>     func = lambda: self.check(nice, **test)
>   File "/root/freeipa-master/ipatests/test_xmlrpc/xmlrpc_test.py", line 297, in
> check
>     self.check_exception(nice, cmd, args, options, expected)
>   File "/root/freeipa-master/ipatests/test_xmlrpc/xmlrpc_test.py", line 323, in
> check_exception
>     assert_deepequal(expected.strerror, e.strerror)
>   File "/root/freeipa-master/ipatests/util.py", line 352, in assert_deepequal
>     VALUE % (doc, expected, got, stack)
> AssertionError: assert_deepequal: expected != got.
> 
>   expected = u"invalid 'hostname': invalid domain-name: only letters, numbers,
> and - are allowed. DNS label may not start or end with -"
>   got = u"invalid 'hostname': invalid domain-name: only letters, numbers, '-'
> are allowed. DNS label may not start or end with '-'"
>   path = ()
> 
> Martin

Sorry for that, patch 0028 fix it.
Patch 0028 should be applied after 0027 to ipa-3-3 branch.
Patch 0028 should be applied to master branch too.

Patches attached.
-- 
Martin^2 Basti
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0028-1-FIX-test_host_plugin-for-DNS-Classless-Reverse-zones.patch
Type: text/x-patch
Size: 1231 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140212/24e97db4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0027-1-DNS-tests-classless-domains-3-3-backport.patch
Type: text/x-patch
Size: 18738 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140212/24e97db4/attachment-0001.bin>