[Freeipa-devel] [PATCH 0043] Remove NULLS from constants.py

[Jan Pazdziora]

On Fri, Feb 21, 2014 at 11:42:45AM -0500, Nathaniel McCallum wrote:
> In the parameters system, we have been checking for a positive list of
> values which get converted to None. The problem is that this method can
> in some cases throw warnings when type coercion doesn't work
> (particularly, string to unicode). Instead, any values that evaluate to
> False that are neither numeric nor boolean should be converted to None.

> >From 98911a96a9b023081458e0f3674bf8096f8f5c43 Mon Sep 17 00:00:00 2001
> From: Nathaniel McCallum <npmccallum at redhat.com>
> Date: Fri, 21 Feb 2014 11:38:32 -0500
> Subject: [PATCH] Remove NULLS from constants.py
> 
> In the parameters system, we have been checking for a positive list of values
> which get converted to None. The problem is that this method can in some
> cases throw warnings when type coercion doesn't work (particularly, string
> to unicode). Instead, any values that evaluate to False that are neither
> numeric nor boolean should be converted to None.

[...]

Ack, all original values pass the _is_null() test.

-- 
Jan Pazdziora
Principal Software Engineer, Identity Management Engineering, Red Hat